<html>
<head><meta charset="utf-8"><title>Meeting 2021-06-29 · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html">Meeting 2021-06-29</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="244246283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244246283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244246283">(Jun 29 2021 at 08:11)</a>:</h4>
<p>Meeting <time datetime="2021-06-29T15:00:00Z">2021-06-29T17:00:00+02:00</time> </p>
<p>Agenda:</p>
<ul>
<li>Triage</li>
<li>Stabilize <code>cargo clippy --fix</code> <a href="https://github.com/rust-lang/rust-clippy/issues/7405">rust-clippy#7405</a></li>
<li>...?</li>
</ul>



<a name="244295369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295369">(Jun 29 2021 at 15:00)</a>:</h4>
<p>Meeting time <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="244295416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295416">(Jun 29 2021 at 15:00)</a>:</h4>
<p><span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="244295604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295604">(Jun 29 2021 at 15:01)</a>:</h4>
<p>hej hej!</p>



<a name="244295719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295719">(Jun 29 2021 at 15:01)</a>:</h4>
<ul>
<li><code>disallowed_script_idents</code> <a href="https://github.com/rust-lang/rust-clippy/pull/7400">https://github.com/rust-lang/rust-clippy/pull/7400</a></li>
</ul>



<a name="244295767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295767">(Jun 29 2021 at 15:02)</a>:</h4>
<p>This should be a really quick one:</p>
<ul>
<li>With the sync on Thursday, we'll get the new clippy::suspicious group into nightly</li>
<li>We stabilized <code>cargo clippy --fix</code> </li>
</ul>
<p>Do you have anything to discuss or any issues I should know of before the sync? <span class="user-mention" data-user-id="261224">@triagebot</span> end-topic</p>



<a name="244295771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295771">(Jun 29 2021 at 15:02)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="244295934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244295934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244295934">(Jun 29 2021 at 15:02)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> I haven't really followed the <code>disallowed_script_idents</code> PR, can you give a summary?</p>



<a name="244296658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244296658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244296658">(Jun 29 2021 at 15:06)</a>:</h4>
<p>sure</p>



<a name="244296712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244296712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244296712">(Jun 29 2021 at 15:07)</a>:</h4>
<p>so RFC 2457 (which i worked on) added non ascii idents to rust</p>



<a name="244296743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244296743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244296743">(Jun 29 2021 at 15:07)</a>:</h4>
<p>i designed a number of carefully-put-together lints for it</p>



<a name="244296800"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244296800" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244296800">(Jun 29 2021 at 15:07)</a>:</h4>
<p>using my unicode background and doing a bunch of research/spec reading</p>



<a name="244296970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244296970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244296970">(Jun 29 2021 at 15:08)</a>:</h4>
<p>this PR wishes to add more lints that are stricter. the initial approach was something i'd rejected while designing the RFC because it would make a bad lint, but I managed to steer the discussion towards a restriction lint that works off of a config</p>



<a name="244297025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297025">(Jun 29 2021 at 15:08)</a>:</h4>
<p>but it's still kinda nuanced so having more eyes on it would be great</p>



<a name="244297029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297029">(Jun 29 2021 at 15:08)</a>:</h4>
<p>that's all</p>



<a name="244297206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297206">(Jun 29 2021 at 15:09)</a>:</h4>
<p>Yeah, I pinged you on the first PR, since I saw your name come up with the rustc lints, and also was really unsure about the first version.</p>
<p>Would you be inclined to accept the version in the new PR?</p>



<a name="244297209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297209">(Jun 29 2021 at 15:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">flip1995</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-06-29/near/244295767">said</a>:</p>
<blockquote>
<p>Do you have anything to discuss or any issues I should know of before the sync?</p>
</blockquote>
<p>I think merging <a href="https://github.com/rust-lang/rust-clippy/issues/7407">rust-clippy#7407</a> before the sync would be nice, as m-ou-se said that it's semi blocking <a href="https://github.com/rust-lang/rust/issues/85746">#85746</a>. I've requested some changes during the review, so it depends on when they get implemented, I guess</p>



<a name="244297527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297527">(Jun 29 2021 at 15:11)</a>:</h4>
<p>Oh yeah, I think both PRs by m-ou-se are worth getting in before the sync. Thanks for pointing that out!</p>



<a name="244297748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297748">(Jun 29 2021 at 15:12)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> yep, inclined to accept, also need to have more time to review and make sure it's good</p>



<a name="244297766"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244297766" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244297766">(Jun 29 2021 at 15:12)</a>:</h4>
<p>but the new pr is in the right _shape_</p>



<a name="244298036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244298036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244298036">(Jun 29 2021 at 15:14)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span>  Ok, I'll take a look at the <code>disallowed_script_idents</code> PR <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span>  Since you have spent the most time on this topic it should ultimately be your decision what version gets merged.</p>



<a name="244298137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-06-29/near/244298137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-06-29.html#244298137">(Jun 29 2021 at 15:14)</a>:</h4>
<p>Ok, that should be it for today then! Thanks for attending! <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>